Skip to content

Added clause hooks for CONSTRUCT statement.#69

Merged
xllora merged 2 commits into
google:masterfrom
apr94:working_construct_clause_hooks
May 23, 2017
Merged

Added clause hooks for CONSTRUCT statement.#69
xllora merged 2 commits into
google:masterfrom
apr94:working_construct_clause_hooks

Conversation

@apr94
Copy link
Copy Markdown
Contributor

@apr94 apr94 commented May 23, 2017

No description provided.

Comment thread bql/grammar/grammar.go
setElementHook(semanticBQL, varSymbols, semantic.VarAccumulatorHook(), nil)

// Collect and valiadate group by bindinds.
// Collect and validate group by bindings.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

Comment thread bql/semantic/hooks.go
}

// whereObjectClause returns an element hook that updates the object
// varAccumulator returns an element hook that updates the object
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

st := &Statement{}
f(st, Symbol("FOO"))
if got, want := st.Type(), Insert; got != want {
t.Errorf("semantic.TypeBidingHook failed to set the right type; got %s, want %s", got, want)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow...

want bool
}{
{
id: "missing biding",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:'(

want: false,
},
{
id: "all bidings available",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:'(

@xllora xllora merged commit 98d8466 into google:master May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants