Reification hooks and tests#72
Merged
Merged
Conversation
xllora
approved these changes
May 30, 2017
| } | ||
| p, err := NewParser(SemanticBQL()) | ||
| if err != nil { | ||
| t.Errorf("grammar.NewParser: should have produced a valid BQL parser, %v", err) |
Member
There was a problem hiding this comment.
grammar.NewParser: Should have produced a valid BQL parser
| for _, entry := range table { | ||
| st := &semantic.Statement{} | ||
| if err := p.Parse(NewLLk(entry.query, 1), st); err != nil { | ||
| t.Errorf("Parser.consume: failed to accept valid semantic entry %q", entry.query) |
Member
There was a problem hiding this comment.
Parser.consume: Failed to accept valid semantic entry %q
| ?s1 "old_predicate_3"@[,] ?o3};`, | ||
| want_one: 2, | ||
| want_two: 2, | ||
| }, |
Member
There was a problem hiding this comment.
Please repeat the tests using temporal predicates.
xllora
requested changes
May 30, 2017
| "predicate_2"@[] ?o2; | ||
| "predicate_3"@[?t] ?o3} into ?a from ?b where {?s "old_predicate_1"@[,] ?o1. | ||
| ?s "old_predicate_2"@[,] ?o2. | ||
| ?s1 "old_predicate_3"@[?t] ?o3};`, |
Member
There was a problem hiding this comment.
?s1 "old_predicate_3"@[?t] ?o3
This is not a valid statement. The valid representation is by using the AT binding keyword. See the example below.
?s1 "old_predicate_3"@[,] AT ?t ?o3
Contributor
Author
There was a problem hiding this comment.
I have fixed this example.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, construct clauses can be fully expressed via the
Statementstruct.