Fix DoNotOptimize compilation error with partially const structs (Fixes #1997)#2246
Open
MaciekChoszczyk wants to merge 1 commit into
Open
Fix DoNotOptimize compilation error with partially const structs (Fixes #1997)#2246MaciekChoszczyk wants to merge 1 commit into
MaciekChoszczyk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1997.
What's wrong?
Passing structs with
constmembers toDoNotOptimizecauses compilation errors because theasmconstraints (+m,+r) request write access to memory that the compiler considersconst.Fix
Cast the input value to a raw byte array (
char(&)[sizeof(Tp)]) to stripconstqualifiers for the optimizer. This safely allows write access in the assembly block.Notes
const_castis not removing 'const' from internal struct members.std::bit_castwas considered but avoided to maintain compatibility with older C++ standards.