Merged
Conversation
Contributor
Author
Missed that. Fixed now |
Contributor
Author
|
As I said in the description:
|
Contributor
Author
This is mostly because of go version bump in go.mod, which requires newer golangci-lint. |
Collaborator
|
@kolyshkin apologies! |
Collaborator
|
@kolyshkin #3615 has now been merged. |
Perhaps I'm missing something here, but it doesn't make any sense as run_tests do not use arguments. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
Updated; probably no longer a draft but I need to see a CI run to make sure. |
This bumps a few runc deps, and removes a few that we were able to decouple from. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
this would be immensely helpful, thanks! edit: @mythi would love to see this CI run as well. |
Collaborator
|
@kolyshkin once you move it off draft, i am happy to try to merge this |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's
switch to go1.22 as the minimally supported version;(obsoleted by PR bump containerd related deps: api v1.8.0; errdefs v1.0.0; ttrpc v1.2.6 #3622)add go1.23 to CI, remove go1.21 (no longer supported);((obsoleted by PR bump containerd related deps: api v1.8.0; errdefs v1.0.0; ttrpc v1.2.6 #3622)Currently a draft pending #3615 merge. I'll rebase once that one is merged.Fixes: #3513