fix potential hang on containerd client.LoadContainer#3672
Merged
cwangVT merged 1 commit intogoogle:masterfrom Mar 14, 2025
Merged
fix potential hang on containerd client.LoadContainer#3672cwangVT merged 1 commit intogoogle:masterfrom
cwangVT merged 1 commit intogoogle:masterfrom
Conversation
Signed-off-by: lianghao208 <roylizard3@gmail.com>
Contributor
Author
SuperQ
approved these changes
Mar 12, 2025
Contributor
Author
|
kindly ping @cwangVT , might need your approval for pending workflow, thanks |
Contributor
Author
|
@bobbypage can you review this? thanks:) |
Contributor
Author
|
@dims @bobbypage @cwangVT @SuperQ Can this PR get merged by any chance? It's had a pretty big impact on kubelet. If cadvisor hangs on |
Contributor
Author
|
Could relate to this: kubernetes/kubernetes#102481 |
Contributor
|
Sorry, I have no authority here. I am not a Google employee. |
cwangVT
approved these changes
Mar 14, 2025
Contributor
Author
|
@cwangVT thanks for the approval. Can you skip the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #3671
add timeout context for containerd factory during starting process.