Skip to content

Let us try to use ghcr.io for container images#3699

Merged
dims merged 1 commit intogoogle:masterfrom
dims:use-ghcr.io-for-container-images
Jun 16, 2025
Merged

Let us try to use ghcr.io for container images#3699
dims merged 1 commit intogoogle:masterfrom
dims:use-ghcr.io-for-container-images

Conversation

@dims
Copy link
Collaborator

@dims dims commented Jun 16, 2025

Going to merge and experiment

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims requested a review from Copilot June 16, 2025 14:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new GitHub Actions workflow to build and publish container images to ghcr.io.

  • Adds a new workflow file to trigger on tag pushes and manual dispatch.
  • Implements steps for checkout, QEMU setup, Docker Buildx setup, disk cleanup, registry login, metadata extraction, and container build-push.

@dims dims merged commit 159a7b2 into google:master Jun 16, 2025
7 checks passed
spenes added a commit to snowplow/snowplow-mini that referenced this pull request Oct 2, 2025
- Collector 3.7.0
- Enrich 6.1.2
- Postgres 16.10-alpine
- Cadvisor 0.53.0

ghcr.io is used to fetch cadvisor container image since
it is moved to ghcr.io: google/cadvisor#3699
spenes added a commit to snowplow/snowplow-mini that referenced this pull request Oct 2, 2025
- Collector 3.7.0
- Enrich 6.1.2
- Postgres 16.10-alpine
- Cadvisor 0.53.0

ghcr.io is used to fetch cadvisor container image since
it is moved to ghcr.io: google/cadvisor#3699
@VaismanLior
Copy link

Hey @dims
Looks like this PR changed the tagging convention of the cadvisor images in the latest release.
The latest version is tagged as ghcr.io/google/cadvisor:0.54.0 without the v prefix while previous versions had it.
Is this on purpose?

@dims
Copy link
Collaborator Author

dims commented Dec 4, 2025

this is what is coded in our scripts now, so let's just leave it at that?

@VaismanLior
Copy link

VaismanLior commented Dec 4, 2025

I would fix it to not break backwards compatibility for helm deployments etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants