feat(summary): add count in percentiles#3729
Merged
dims merged 1 commit intogoogle:masterfrom Dec 10, 2025
Merged
Conversation
sambhav-jain-16
force-pushed
the
percentle-count
branch
2 times, most recently
from
85bb196 to
07bd759
Compare
Contributor
Author
|
Hi @cwangVT |
Contributor
Author
|
Hi @dims |
Collaborator
|
@sambhav-jain-16 please rebase, also in your experience, will this break any existing folks that consume this percentile? (as we added a new field?) |
To measure the quality of the derived metric, it is necessary to also store the count of the samples from which the percentile calculation is being done. This commit aims to add this feature in cadvisor.
sambhav-jain-16
force-pushed
the
percentle-count
branch
from
07bd759 to
58def56
Compare
Contributor
Author
|
@dims done
Since it is a change in struct, it shouldn't break anything. This change is already deployed in our infra and is running without breaking during rollout. |
Collaborator
|
@sambhav-jain-16 thanks for confirming |
dims
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To measure the quality of the derived metric, it is necessary to also store the count of the samples from which the percentile calculation is being done. This commit aims to add this feature in cadvisor.