ci: update Ubuntu version to 24.04 in GitHub Actions workflows#3754
Merged
dims merged 5 commits intogoogle:masterfrom Dec 3, 2025
Merged
ci: update Ubuntu version to 24.04 in GitHub Actions workflows#3754dims merged 5 commits intogoogle:masterfrom
dims merged 5 commits intogoogle:masterfrom
Conversation
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
force-pushed
the
update-from-ubuntu-22.04-to-24.04
branch
2 times, most recently
from
60fc669 to
2d4de23
Compare
The Client() function uses sync.Once to initialize the client, but stored the error in a local variable. If the first call failed, subsequent calls would return (nil, nil) because sync.Once wouldn't run again and the local error variable would be freshly initialized to nil. This caused a panic when containerd wasn't available - the docker factory would fail first, then the containerd factory would get a nil client with no error and crash when calling client.Version(). Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Add logging before cAdvisor starts to capture: - Docker version and info - Containerd socket availability - Docker socket availability - Running docker/containerd processes - Kernel version This will help debug why containerd socket is not available on Ubuntu 24.04 GitHub Actions runners. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Mesos is no longer actively maintained and has been deprecated. Remove the Mesos container factory to reduce code complexity and maintenance burden. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Docker-in-Docker setups run containerd at /run/docker/containerd/containerd.sock instead of the default /run/containerd/containerd.sock. Detect and use the correct socket path when starting cAdvisor in integration tests. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
force-pushed
the
update-from-ubuntu-22.04-to-24.04
branch
from
2d4de23 to
5f2438b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move from 22.04 to 24.04