Reduce lock contention in cache/memory package#3762
Merged
dims merged 1 commit intogoogle:masterfrom Dec 4, 2025
Merged
Conversation
Replace the global RWMutex-protected map with sync.Map in InMemoryCache. This provides lock-free reads for the common path (RecentStats lookups) while maintaining thread-safe writes. Add containerCacheMap typed wrapper around sync.Map to eliminate boilerplate type assertions and improve code readability. Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the global
sync.RWMutex-protected map withsync.MapinInMemoryCacheto eliminate lock contention during concurrent cache access.Changes
sync.RWMutex+map[string]*containerCachewithsync.MapLoadfor lock-free reads inRecentStatsLoadOrStorepattern inAddStatsfor atomic container creationcontainerCacheMaptyped wrapper to eliminate type assertions at call sitesBenchmark Results
Performance improvement: 2.5x faster for mixed read/write workloads (99% reads, 1% writes)
For the benchmark methodology and detailed performance analysis, see #3756 which applies the same pattern to the manager package.