feat: add exit code in container deletion events#3779
Merged
dims merged 1 commit intogoogle:masterfrom Dec 11, 2025
Merged
Conversation
Collaborator
|
@sambhav-jain-16 which container engines did you fully test this on? (containerd only?) |
Contributor
Author
|
@dims (Not exactly the same code, but we are consuming the current deletion events and then hitting the same docker/containerd APIs to get the exit code) |
dims
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Container deletion events now include the container's exit code in the event data.
Fixes: #3722
Why
Users need to understand why containers terminated (success vs error vs signal). Exit codes provide critical debugging information for container lifecycle management and monitoring.
How
GetExitCode()method to ContainerHandler interfaceContainerDeletionEventDatastruct with ExitCode field to event systemdestroyContainer()to retrieve exit code before callingStop()Testing
API Example