fix: correct cgroup v2 swap memory calculation (#3823)#3845
Open
Elvand-Lie wants to merge 1 commit intogoogle:masterfrom
Open
fix: correct cgroup v2 swap memory calculation (#3823)#3845Elvand-Lie wants to merge 1 commit intogoogle:masterfrom
Elvand-Lie wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
43c338f to
9f700a7
Compare
Contributor
|
Thank you very much for addressing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3823
Problem:
In cgroup v2 environments,
cAdvisoris currently reporting zero swap metrics even when swap is active. This is due tohandler.goapplying legacy cgroup v1 math (SwapUsage - Usage). In v2,memory.swap.currentis decoupled from RAM usage, so subtractingUsageincorrectly zeroes out the metric.Solution:
Updated the
IsCgroup2UnifiedMode()block to assignSwapUsage.Usagedirectly toret.Memory.Swapwithout the legacy subtraction.Notes:
go fmt.handler.go.