Skip to content

Escape forward slashes in certificate Subject names when used as user quota id strings #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlCutter merged 3 commits into from
Jun 12, 2023
Merged

Escape forward slashes in certificate Subject names when used as user quota id strings #1059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12bbf51
Escape forward slashes in user quota id strings
robstradling Apr 21, 2023
ac22ed1
Update CHANGELOG.md
robstradling Apr 21, 2023
f376497
Update CHANGELOG.md
robstradling May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@

### Chrome CT Policy Update
* #906: Update chromepolicy.go to follow the updated Chrome CT policy.


### Misc
* #1059: Escape forward slashes in certificate Subject names when used as user quota id strings.

## v1.1.6

## Dependency update
Expand All @@ -29,7 +32,7 @@

* Remove v2 log list package files.

### Misc
### Misc

* Updated golangci-lint to v1.51.1 (developers should update to this version).
* Bump Go version from 1.17 to 1.19.
Expand Down
3 changes: 2 additions & 1 deletion trillian/ctfe/cert_quota.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"crypto/sha256"
"encoding/hex"
"fmt"
"strings"

"github.com/google/certificate-transparency-go/x509"
)
Expand All @@ -38,5 +39,5 @@ const CertificateQuotaUserPrefix = "@intermediate"
// See tests for examples.
func QuotaUserForCert(c *x509.Certificate) string {
spkiHash := sha256.Sum256(c.RawSubjectPublicKeyInfo)
return fmt.Sprintf("%s %s %s", CertificateQuotaUserPrefix, c.Subject.String(), hex.EncodeToString(spkiHash[0:5]))
return fmt.Sprintf("%s %s %s", CertificateQuotaUserPrefix, strings.ReplaceAll(c.Subject.String(), "/", "%2F"), hex.EncodeToString(spkiHash[0:5]))
}