This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Split out VerifiableMap from SparseMerkleTree.#1061
Merged
AlCutter merged 1 commit intogoogle:masterfrom Nov 23, 2015
Merged
Conversation
cpp/merkletree/sparse_merkle_tree.h
Outdated
Contributor
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
hehe, ok - made explicit.
Contributor
|
Done with the review, just make the hash explicit (instead of specializing |
AlCutter
force-pushed
the
split_smt_and_verifiable_map
branch
2 times, most recently
from
a656dbf to
c905a6f
Compare
Member
Author
There was a problem hiding this comment.
This is because you get back a const T* from the std::array::data(), so I'd need to actively const_cast it away.
Contributor
|
One nit, but LGTM otherwise. |
AlCutter
force-pushed
the
split_smt_and_verifiable_map
branch
from
c905a6f to
93d82b4
Compare
AlCutter
force-pushed
the
split_smt_and_verifiable_map
branch
from
93d82b4 to
89ac279
Compare
AlCutter
added a commit
that referenced
this pull request
Nov 23, 2015
Split out VerifiableMap from SparseMerkleTree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.