Accelerators#319
Merged
Merged
Conversation
ser-io
requested review from
adelva1984,
jemoreira,
jmacnak and
rmuthiah
as code owners
ser-io
force-pushed
the
accelerators
branch
2 times, most recently
from
d63e1a2 to
57faebd
Compare
Databean
approved these changes
Jun 3, 2024
| MachineType string | ||
| MinCPUPlatform string | ||
| // List of comma separated `key=value` pairs, i.e `type=nvidia-tesla-p100,count=1`. | ||
| AcceleratorConfigs []string |
Member
There was a problem hiding this comment.
Can this be a string->string map?
https://google.aip.dev/apps/2717 suggests a string->string map for storing generic data, and go/apidosdonts#dont-encode-data-in-a-string writes
Don’t Encode Data in a String That You Expect a Client to Construct or Parse
Member
Author
There was a problem hiding this comment.
Done. This struct is not meant to be serialized, however I moved the parsing logic to an early stage allowing us to define a more specific structure. Thanks.
- Allows to add accelerator cards to hosts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.