Win32: Warning on wrong preprocessor syntax Issue #1031#1032
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ptc-tgamper
commented
Nov 24, 2023
file_writer_utils.cc - fix preprocessor check and wrong path check
ptc-tgamper
force-pushed
the
bug/issue1031
branch
from
1694501 to
473719b
Compare
Merged
ondys
approved these changes
Jan 11, 2024
Collaborator
ondys
left a comment
ondys
left a comment
There was a problem hiding this comment.
Thanks for the PR. Looks good.
danielgronlund
pushed a commit
to danielgronlund/draco
that referenced
this pull request
Aug 22, 2024
file_writer_utils.cc - fix preprocessor check and wrong path check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file_writer_utils.cc - fix preprocessor check and wrong path check