Skip to content

Fix some javascript issues. #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomfinegan merged 2 commits into from
Aug 27, 2019
Merged

Fix some javascript issues. #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
935f182
draco js: Silence binyaren warning
tomfinegan Aug 27, 2019
092426c
draco js: Fix omitted update of ERROR -> DRACO_ERROR
tomfinegan Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,8 +674,6 @@ if(EMSCRIPTEN AND ENABLE_JS_GLUE)
require_compiler_flag("-s PRECISE_F32=1" YES)
if(ENABLE_WASM)
require_compiler_flag("-s WASM=1" YES)
else()
require_compiler_flag("-s ELIMINATE_DUPLICATE_FUNCTIONS=1" YES)
endif()
if(IE_COMPATIBLE)
require_compiler_flag("-s LEGACY_VM_SUPPORT=1" YES)
Expand Down
2 changes: 1 addition & 1 deletion src/draco/javascript/emscripten/draco_animation_web_decoder.idl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ interface DecoderBuffer {

enum draco_StatusCode {
"draco_Status::OK",
"draco_Status::ERROR",
"draco_Status::DRACO_ERROR",
"draco_Status::IO_ERROR",
"draco_Status::INVALID_PARAMETER",
"draco_Status::UNSUPPORTED_VERSION",
Expand Down
2 changes: 1 addition & 1 deletion src/draco/javascript/emscripten/draco_web_decoder.idl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ interface Metadata {

enum draco_StatusCode {
"draco_Status::OK",
"draco_Status::ERROR",
"draco_Status::DRACO_ERROR",
"draco_Status::IO_ERROR",
"draco_Status::INVALID_PARAMETER",
"draco_Status::UNSUPPORTED_VERSION",
Expand Down