Add transcoder testing to Draco's Github CI tests.#821
Merged
Conversation
The main addition here is the new function build_and_install_transcoder_dependencies(). It does what its name claims: builds and/or install Draco dependencies for transcoder enabled builds. In addition: - The flag -t/--with_transcoder has been added to allow for optionally enabling the additional testing support. - Verbose mode cleanup: stop double output of command output output.
… it must be defined here.
There is no need to perform the check if T is of type bool, since it is guaranteed to fit in all other integral types. This avoids triggering a C4804 warning in Visual Studio, ie. `unsafe use of type 'bool' in operation`
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.1 to 1.13.3. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.13.1...v1.13.3) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Use a local dupe of a constant to avoid DLL linkage issues on Windows in the GLTF encoder test.. - Define DRACO_PI to avoid M_PI and entertaining include ordering issues related to _USE_MATH_DEFINES and interactions between <cmath> and <math.h> on Windows (fun include guards and order related things).
ondys
approved these changes
Mar 3, 2022
danielgronlund
pushed a commit
to danielgronlund/draco
that referenced
this pull request
Aug 22, 2024
This enabled CI testing of transcoder configs and includes a few minor Windows-only bug fixes. Note that this adds flags to skip GltfDecoderTest.ThreeMeshesOneNoMaterialMesh for Windows MSVC CI builds. See google#826 for details. Windows specific updates (these do impact non-Windows builds, but are essentially a no-op there): - Use a local dupe of a constant to avoid DLL linkage issues on Windows in the GLTF encoder test.. - Define DRACO_PI to avoid M_PI and entertaining include ordering issues related to _USE_MATH_DEFINES and interactions between <cmath> and <math.h> on Windows (fun include guards and order related things). This is done in core/constants.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.