serialize fully qualified struct & enum name in schema binary

[paszea]

See https://groups.google.com/forum/#!topic/flatbuffers/HzLe4L5LNnY for the discussion.

This is the minimum change needed. Let me know if you think it's better to guard it with a flatc flag. For that I'll need to modify the following methods to pass down the flag.

StructDef::Serialize()
EnumDef::Serialize()
Parser::Serialize()

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[ghost]

does this pass the tests? E.g. there is in test.cpp: TEST_EQ_STR(root_table->name()->c_str(), "Monster");

[paszea]

How do you run tests? I ran "make test" in root dir and it passed.

On Wed, Sep 14, 2016 at 11:06 AM, Wouter van Oortmerssen <
notifications@github.com> wrote:

does this pass the tests? E.g. there is in test.cpp:
TEST_EQ_STR(root_table->name()->c_str(), "Monster");

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4024 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADVeu_saAlW05OcqyUWaXTKpGIC3weTKks5qqDfCgaJpZM4J9D5p
.

[paszea]

I signed it

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

[ghost]

cd tests
../flattests

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[paszea]

ok. I regenerated monster_test.bfbs and fixed the test. please have another look.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

[paszea]

abandon this pr. see #4025 instead