[Python] Fix generating __init__.py for invalid path#8810
Merged
jtdavis777 merged 1 commit intogoogle:masterfrom Nov 30, 2025
Merged
[Python] Fix generating __init__.py for invalid path#8810jtdavis777 merged 1 commit intogoogle:masterfrom
jtdavis777 merged 1 commit intogoogle:masterfrom
Conversation
This tried to generate from a directories "MyGame/Sample/" for a empty path_ in M, MyGame & MyGame/Sample. Which is incorrect since we want to start with the first kPathSeparator `/` and not position 1.
github-actions
bot
added
c++
codegen
Contributor
Author
|
Here is a godbolt to play with it -> https://godbolt.org/z/1ab9Wv3P1 |
jtdavis777
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tried to generate from a directories "MyGame/Sample/" for a empty path_ in M, MyGame & MyGame/Sample.
Which is incorrect since we want to start with the first kPathSeparator
/and not position 1.Fixes #8787
In the future i want to address the issue that the Save does just silently ignore the wrong path.