[C++] Allow pushing null value to vector (fixes #8424)#8862
[C++] Allow pushing null value to vector (fixes #8424)#8862shikharish wants to merge 2 commits intogoogle:masterfrom
Conversation
|
@jtdavis777 Request for review. |
|
Hey! Thanks for the PR -- I think a test for this feature would be useful. |
|
I ran |
Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
5f8d046 to
7f56374
Compare
|
Things must be getting out of sync -- I 'm also dimly aware of the fact that clang-format may have some style preference differences between versions, so you may be encountering that. I would not stress it for this PR if you can manually ensure you're reasonably within the style, and we can submit a separate catch-up PR if needed. |
|
Alright, I'll submit another PR after this one gets merged. |
|
this one LGTM - I believe @dbaileychess is working on the repo right now and so merging is paused for a little while but I'll make sure this gets in once that is complete. |
|
@shikharish there is a bazel test compilation failure - can you take a look? |
|
Sorry this should not be merged, see my comment on the original issue. |
Fixes #8424.