Skip to content

Comments

[C++] Allow pushing null value to vector (fixes #8424)#8862

Closed
shikharish wants to merge 2 commits intogoogle:masterfrom
shikharish:null_value_push
Closed

[C++] Allow pushing null value to vector (fixes #8424)#8862
shikharish wants to merge 2 commits intogoogle:masterfrom
shikharish:null_value_push

Conversation

@shikharish
Copy link

Fixes #8424.

@github-actions github-actions bot added the c++ label Dec 17, 2025
@shikharish
Copy link
Author

@jtdavis777 Request for review.

@jtdavis777
Copy link
Collaborator

Hey! Thanks for the PR -- I think a test for this feature would be useful.

@shikharish
Copy link
Author

I ran scripts/clang-format-all.sh and it formats many unchanged files. Should I submit those formatting changes in this PR itself?

Signed-off-by: Shikhar Soni <shikharish05@gmail.com>
@jtdavis777
Copy link
Collaborator

Things must be getting out of sync -- I 'm also dimly aware of the fact that clang-format may have some style preference differences between versions, so you may be encountering that. I would not stress it for this PR if you can manually ensure you're reasonably within the style, and we can submit a separate catch-up PR if needed.

@shikharish
Copy link
Author

Alright, I'll submit another PR after this one gets merged.

@jtdavis777
Copy link
Collaborator

this one LGTM - I believe @dbaileychess is working on the repo right now and so merging is paused for a little while but I'll make sure this gets in once that is complete.

@jtdavis777 jtdavis777 added the ready-for-merge This PR has been approved by a maintainer and is ready for merge by a code owner label Dec 20, 2025
@jtdavis777
Copy link
Collaborator

@shikharish there is a bazel test compilation failure - can you take a look?

@aardappel
Copy link
Collaborator

Sorry this should not be merged, see my comment on the original issue.

@jtdavis777 jtdavis777 self-requested a review December 22, 2025 01:44
@jtdavis777 jtdavis777 removed the ready-for-merge This PR has been approved by a maintainer and is ready for merge by a code owner label Dec 22, 2025
@shikharish shikharish closed this Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++] can't insert null value in vector

3 participants