Skip to content

Fix compatibility with Flask 3 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidwtbuxton merged 1 commit into from
Oct 11, 2023
Merged

Fix compatibility with Flask 3 #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10']
python-version: ['3.8', '3.9', '3.10', '3.11']
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
Expand Down
6 changes: 4 additions & 2 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@
nox.options.default_venv_backend = "venv"


@nox.session(python=["3.7", "3.8", "3.9", "3.10"])
def tests(session):
@nox.session(python=["3.8", "3.9", "3.10", "3.11"])
@nox.parametrize("flask", ["2", "3"])
def tests(session, flask):
session.install("pytest")
session.install(f"flask~={flask}.0")
session.install(".")
session.run("pytest", "--disable-warnings")
4 changes: 2 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Flask
Flask>=2.0
flask-talisman
flask-seasurf
flask-seasurf @ https://github.com/maxcountryman/flask-seasurf/archive/f383b482c69e0b0e8064a8eb89305cea3826a7b6.zip
google-cloud-ndb
2 changes: 1 addition & 1 deletion src/securescaffold/tests/test_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def test_create_app_adds_other_security_headers(ndb_client):
assert response.headers["Referrer-Policy"] == "strict-origin-when-cross-origin"
assert response.headers["X-Content-Type-Options"] == "nosniff"
assert response.headers["X-Frame-Options"] == "SAMEORIGIN"
assert response.headers["X-Xss-Protection"] == "1; mode=block"
assert "X-Xss-Protection" not in response.headers


def test_extra_flask_args(ndb_client):
Expand Down