Add function for redelivering webhooks#2061
Merged
gmlewis merged 5 commits intogoogle:masterfrom Sep 3, 2021
DeviousLab:redeliver-webhook
Merged
Add function for redelivering webhooks#2061gmlewis merged 5 commits intogoogle:masterfrom DeviousLab:redeliver-webhook
gmlewis merged 5 commits intogoogle:masterfrom
DeviousLab:redeliver-webhook
Conversation
Signed-off-by: DeviousLab <deviouslab@gmail.com>
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2061 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 107 107
Lines 9600 9612 +12
=======================================
+ Hits 9384 9396 +12
Misses 150 150
Partials 66 66
Continue to review full report at Codecov.
|
gmlewis
requested changes
Aug 24, 2021
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @DeviousLab !
This is a good start. Please add a new unit test for the new method and make sure to run gofmt on your added code.
gmlewis
reviewed
Aug 24, 2021
gmlewis
changed the title
As suggested by gmlewis Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: DeviousLab <deviouslab@gmail.com>
…github into redeliver-webhook
Signed-off-by: DeviousLab <deviouslab@gmail.com>
gmlewis
approved these changes
Aug 25, 2021
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @DeviousLab !
LGTM.
Awaiting second LGTM before merging.
Collaborator
|
Thank you, @Parker77 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to resolve issue #2060. Let me know if I've done it wrong!
Signed-off-by: DeviousLab deviouslab@gmail.com
Fixes: #2060.