Add support for check private vulnerability reporting endpoint#3157
Add support for check private vulnerability reporting endpoint#3157gmlewis merged 10 commits intogoogle:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3157 +/- ##
==========================================
- Coverage 97.72% 92.89% -4.84%
==========================================
Files 153 170 +17
Lines 13390 11466 -1924
==========================================
- Hits 13085 10651 -2434
- Misses 215 724 +509
- Partials 90 91 +1 ☔ View full report in Codecov by Sentry. |
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Sairaviteja27 !
github/repos.go
Outdated
| // CheckPrivateReporting represents whether private vulnerability reporting is enabled. | ||
| type CheckPrivateReporting struct { |
There was a problem hiding this comment.
This should be private since it isn't exposed anywhere to the end-user.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
…iraviteja27/go-github into check-pvt-vuln-report-enabled
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Sairaviteja27 !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
@gmlewis I think code coverage check is failing. Could you suggest if I should I add tests in other methods? |
Don't worry about that. We've had some weirdness with codecov lately and I've made two reports with the problems we've seen and don't have any resolution yet. Thanks, though. |
|
Thank you, @be0x74a ! |
3 participants
fixes #3152