Skip to content

Add support for App Callback URLs #3204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 5 commits into from
Jul 10, 2024
Merged

Add support for App Callback URLs #3204

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ea2a04
Add support for App Callback URL (#3203)
Roming22 Jul 10, 2024
0c830b3
fix JSON field
Roming22 Jul 10, 2024
cd54c04
chore: add link to github doc describing the manifest
Roming22 Jul 10, 2024
d7769ed
fix: Use 'CallbackURLs'
Roming22 Jul 10, 2024
37af254
Update scrape/apps.go
Roming22 Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scrape/apps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,14 @@ type OAuthApp struct {

// AppManifest represents a GitHub App manifest, used for preconfiguring
// GitHub App configuration.
// c.f. https://docs.github.com/en/apps/sharing-github-apps/registering-a-github-app-from-a-manifest
type AppManifest struct {
// The name of the GitHub App.
Name *string `json:"name,omitempty"`
//Required. The homepage of your GitHub App.
URL *string `json:"url,omitempty"`
// The full URL(s) of the endpoint(s) to authenticate users via the GitHub App (Max: 10).
CallbackURLs []string `json:"callback_urls,omitempty"`
// Required. The configuration of the GitHub App's webhook.
HookAttributes map[string]string `json:"hook_attributes,omitempty"`
// The full URL to redirect to after the person installs the GitHub App.
Expand Down