Skip to content

chore: Fix TestNewFormRequest #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 1 commit into from
Feb 26, 2026
Merged

chore: Fix TestNewFormRequest #4043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions github/github_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,17 +661,23 @@ func TestNewFormRequest(t *testing.T) {
form := url.Values{}
form.Add("login", "l")
inBody, outBody := strings.NewReader(form.Encode()), "login=l"
req, _ := c.NewFormRequest(inURL, inBody)
req, err := c.NewFormRequest(inURL, inBody)
if err != nil {
t.Fatalf("NewFormRequest returned unexpected error: %v", err)
}

// test that relative URL was expanded
if got, want := req.URL.String(), outURL; got != want {
t.Errorf("NewFormRequest(%q) URL is %v, want %v", inURL, got, want)
}

// test that body was form encoded
body, _ := io.ReadAll(req.Body)
body, err := io.ReadAll(req.Body)
if err != nil {
t.Fatalf("Error reading request body: %v", err)
}
if got, want := string(body), outBody; got != want {
t.Errorf("NewFormRequest(%q) Body is %v, want %v", inBody, got, want)
t.Errorf("NewFormRequest() Body is %v, want %v", got, want)
}

// test that default user-agent is attached to the request
Expand All @@ -681,13 +687,16 @@ func TestNewFormRequest(t *testing.T) {

apiVersion := req.Header.Get(headerAPIVersion)
if got, want := apiVersion, defaultAPIVersion; got != want {
t.Errorf("NewRequest() %v header is %v, want %v", headerAPIVersion, got, want)
t.Errorf("NewFormRequest() %v header is %v, want %v", headerAPIVersion, got, want)
}

req, _ = c.NewFormRequest(inURL, inBody, WithVersion("2022-11-29"))
req, err = c.NewFormRequest(inURL, inBody, WithVersion("2022-11-29"))
if err != nil {
t.Fatalf("NewFormRequest with WithVersion returned unexpected error: %v", err)
}
apiVersion = req.Header.Get(headerAPIVersion)
if got, want := apiVersion, "2022-11-29"; got != want {
t.Errorf("NewRequest() %v header is %v, want %v", headerAPIVersion, got, want)
t.Errorf("NewFormRequest() %v header is %v, want %v", headerAPIVersion, got, want)
}
}

Expand Down
Loading