Rename visibleInWhois fields to visibleInRdap#2863
Merged
Conversation
gbrodman
force-pushed
the
visibleInRdap
branch
3 times, most recently
from
October 28, 2025 18:51
e534c93 to
506f15b
Compare
gbrodman
force-pushed
the
visibleInRdap
branch
2 times, most recently
from
October 29, 2025 20:06
7ce8e74 to
1e1b70e
Compare
Still part of b/454947209, removing references to WHOIS where we can. We keep the registrar type and the column names (at least for now) because changing those is much more complicated.
gbrodman
force-pushed
the
visibleInRdap
branch
from
October 29, 2025 20:16
1e1b70e to
b6852fd
Compare
Collaborator
Author
|
friendly ping |
ptkach
approved these changes
Nov 4, 2025
ptkach
left a comment
ptkach
left a comment
Collaborator
There was a problem hiding this comment.
@ptkach reviewed 28 of 28 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gbrodman)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still part of b/454947209, removing references to WHOIS where we can. We keep the registrar type and the column names (at least for now) because changing those is much more complicated.
This change is