CMake Build Issues on OSx

[ambasta]

This is a bug to track build issues on OSx while using cmake.

The currently known issue is while configuring the project as:

-- The CXX compiler identification is AppleClang 8.1.0.8020042
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/local/bin/pkg-config (found version "0.29.2")
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE
-- Checking for module 'libglog>=0.3.5'
-- Found libglog, version 0.3.5
-- Checking for module 'cbc'
-- Found cbc, version 2.9.6
CMake Error at CMakeLists.txt:79 (ADD_DEPENDENCIES):
add_dependencies called with incorrect number of arguments

PROJECT_NAME seems undefined

[lperron]

running cmake went fine.
It seems something is wrong with CBC config file (it read the brew version).

/Users/lperron/Work/cmake-or-tools/ortools/linear_solver/cbc_interface.cc:35:10: fatal error:
'coin/CbcConfig.h' file not found
#include "coin/CbcConfig.h"

[ambasta]

Should I assume you ran "brew install cbc" to get cbc via brew?

[lperron]

yes.

Looking at CMakeCache.txt, it seems that or-tools does not add the cbc paths to cflags.

CMakeCache.txt

[lperron]

Actually, looking at build/ortools/linear_solver/.../flags.cmake, the -I is there.
So I do not know.

[ambasta]

I've been trying to install cbc via brew, but it keeps throwing configure: error: Required package CoinUtils not available. I've however udpated the build a little which might hopefully address your issues

[ambasta]

Hey @lperron

So I figured out the first issue with system-wide cbc on OSX. pkg-config on brew installed cbc throws the following

pkg-config --cflags-only-I cbc
-I/usr/local/Cellar/cbc/2.9.6/include/cbc/coin -I/usr/local/Cellar/cgl/0.59.6/include/cgl/coin -I/usr/local/Cellar/clp/1.16.7/include/clp/coin -I/usr/local/Cellar/osi/0.107.5/include/osi/coin -I/usr/local/Cellar/coinutils/2.10.10/include/coinutils/coin

At this point, while #include <CbcConfig.h> will succeed #include <coin/CbcConfig.h> fails since coin subdir is already part of the include path.

How are you specifying include paths in the current make tool?

[lperron]

good catch.

As I wrote on the last merge request, I cleaned everything from brew.
It does not build gflags, and forget to link with -lz.

Still, I believe we (you) are making progress.

Thanks

[lperron]

on the include part, is there a flag that tells use we are building using cmake?

[lperron]

I changed the gflags part in CMakeLists.txt to mirror the glog part:

SET(GFLAGS_VERSION ${Gflags_VERSION})
PKG_CHECK_MODULES(GFLAGS libgflags>=${GFLAGS_VERSION})
# Set again since pkg_check_module resets GFLAGS_VERSION
SET(GFLAGS_VERSION ${Gflags_VERSION})
IF(NOT GFLAGS_FOUND)
    MESSAGE(STATUS "Did not find system gflags. Building as an external project.")
    INCLUDE(cmake/external/gflags.cmake)
ENDIF()
INCLUDE_DIRECTORIES(${GFLAGS_INCLUDE_DIRS})

Now it builds gflags.

[ambasta]

Okay, found the issue with gflags as well. gflags ships its CMakeConfig file with project name gflags, not Gflags.. That is case sensitive..

So while find_package(Gflags) works, the variables being set are gflags_LIBRARIES, not Gflags_LIBRARIES!

[lperron]

ok.

BTW, glog should build using gflags. so it should not start build glog before gflags is installed.

[ambasta]

Will specify gflags as a dependency for glog then :)