Skip to content

Update version number to 1.2.0#178

Merged
danilak-G merged 1 commit into
google:mainfrom
jjerphan:build/update-version-to-1.2.0
Apr 10, 2024
Merged

Update version number to 1.2.0#178
danilak-G merged 1 commit into
google:mainfrom
jjerphan:build/update-version-to-1.2.0

Conversation

@jjerphan

@jjerphan jjerphan commented Apr 8, 2024

Copy link
Copy Markdown
Contributor

1.2.0 was released recently, but the version number was not updated, causing some inconsistency for the soname of the dynamic shared library.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@google-cla

google-cla Bot commented Apr 8, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@danlark1

danlark1 commented Apr 8, 2024

Copy link
Copy Markdown

Thank you! Sorry for the confusion, I inherited the project and forgot about that

Can you sign CLA and I'll merge shortly

@jjerphan

jjerphan commented Apr 8, 2024

Copy link
Copy Markdown
Contributor Author

No problem. 🙂

I am waiting for a response to know whether I have to sign the CLA on behalf of QuantStack or not.

@jjerphan

jjerphan commented Apr 9, 2024

Copy link
Copy Markdown
Contributor Author

Hi @danlark1 , I just have signed the CLA.

hswong3i added a commit to alvistack/google-snappy that referenced this pull request Apr 10, 2024
    git clean -xdf
    git submodule sync --recursive
    git submodule update --init --recursive
    git submodule foreach git checkout -- .
    tar zcvf ../snappy_1.2.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp snappy.spec ../snappy_1.2.0-1.spec
    cp ../*snappy*1.2.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/google-snappy-1.2.0/
    rm -rf ../*snappy*1.2.0*.*

See google#178

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@danilak-G

Copy link
Copy Markdown
Collaborator

The check still fails, can you take a look if the email you signed with matches the one of the commit?

@jjerphan

Copy link
Copy Markdown
Contributor Author

Done.

@danilak-G

Copy link
Copy Markdown
Collaborator

Thanks!

@danilak-G danilak-G merged commit 52820ea into google:main Apr 10, 2024
@jjerphan jjerphan deleted the build/update-version-to-1.2.0 branch April 10, 2024 14:17
@jjerphan

Copy link
Copy Markdown
Contributor Author

You are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants