Skip to content

Fix -Wuninitialized-const-pointer for dummy buffer#245

Open
etan-status wants to merge 1 commit into
google:mainfrom
etan-status:constinit
Open

Fix -Wuninitialized-const-pointer for dummy buffer#245
etan-status wants to merge 1 commit into
google:mainfrom
etan-status:constinit

Conversation

@etan-status

Copy link
Copy Markdown

Compiling on macOS produces a -Wuninitialized-const-pointer warning. Initialize to 0 to avoid it.

./snappy-test.cc:469:52: error: variable 'dummyin' is uninitialized when passed as a const pointer argument here [-Werror,-Wuninitialized-const-pointer]
  469 |   if ( UncompressChunkOrAll(&dummyout, &dummylen, &dummyin, 0, Z_FINISH)
      |                                                    ^~~~~~~
1 error generated.
% sw_vers
ProductName:		macOS
ProductVersion:		26.5.2
BuildVersion:		25F84

% clang --version
Apple clang version 21.0.0 (clang-2100.1.1.101)
Target: arm64-apple-darwin25.5.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Compiling on macOS produces a -Wuninitialized-const-pointer warning.
Initialize to 0 to avoid it.

```
./snappy-test.cc:469:52: error: variable 'dummyin' is uninitialized when passed as a const pointer argument here [-Werror,-Wuninitialized-const-pointer]
  469 |   if ( UncompressChunkOrAll(&dummyout, &dummylen, &dummyin, 0, Z_FINISH)
      |                                                    ^~~~~~~
1 error generated.
```

```
% sw_vers
ProductName:		macOS
ProductVersion:		26.5.2
BuildVersion:		25F84

% clang --version
Apple clang version 21.0.0 (clang-2100.1.1.101)
Target: arm64-apple-darwin25.5.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
```
@google-cla

google-cla Bot commented Jul 3, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@etan-status

Copy link
Copy Markdown
Author

It's a BSD project...

@etan-status

etan-status commented Jul 3, 2026

Copy link
Copy Markdown
Author

Also fixes the equivalent -Wmaybe-uninitialized on GCC:

./snappy-test.cc:469:28: warning: ‘dummyin’ may be used uninitialized [-Wmaybe-uninitialized]
  469 |   if ( UncompressChunkOrAll(&dummyout, &dummylen, &dummyin, 0, Z_FINISH)
      |        ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./snappy-test.cc:443:5: note: by argument 4 of type ‘const Bytef*’ {aka ‘const unsigned char*’} to ‘int snappy::ZLib::UncompressChunkOrAll(Bytef*, uLongf*, const Bytef*, uLong, int)’ declared here
  443 | int ZLib::UncompressChunkOrAll(Bytef *dest, uLongf *destLen,
      |     ^~~~
./snappy-test.cc:467:9: note: ‘dummyin’ declared here
  467 |   Bytef dummyin, dummyout;
      |         ^~~~~~~

tersec pushed a commit to status-im/nim-snappy that referenced this pull request Jul 3, 2026
* Disable -Wuninitialized-const-pointer when building snappy

Newer macOS ships with compiler that emits -Wuninitialized-const-pointer
when building upstream snappy.

- google/snappy#245

* Just downgrade the error to warning

* -Wno-unknown-warning-option for backwards compatibility

* Clang / GCC switch

* Bash fix

* Apply suggestion from @etan-status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant