Skip to content

Build static version of lib with cmake#48

Closed
maxhora wants to merge 1 commit into
google:masterfrom
maxhora:cmake-static-lib
Closed

Build static version of lib with cmake#48
maxhora wants to merge 1 commit into
google:masterfrom
maxhora:cmake-static-lib

Conversation

@maxhora

@maxhora maxhora commented Jul 25, 2017

Copy link
Copy Markdown

No description provided.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@maxhora

maxhora commented Jul 25, 2017

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@djsutherland

djsutherland commented Jul 25, 2017

Copy link
Copy Markdown

This is similar to the static-lib part of #38, but adds the static lib as a separate target (snappy_static.lib on Windows, libsnappy.a elsewhere). We're (probably) using this version for now in the conda-forge build.

@pwnall

pwnall commented Jul 31, 2017

Copy link
Copy Markdown
Member

We decided to use the approach in c756f7f for consistency with other Google projects. (FWIW, my main source of inspiration is googletest.)

If you have some reason that you absolutely need to build both the static and the shared library at the same time, please comment and let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants