This repository was archived by the owner on Jan 8, 2024. It is now read-only.
Pass use_default_shell_env=True to ctx.action. - #76
Merged
Conversation
This is necessary under --python_path=python3 and other relative paths, which is in turn necessary to support builds across multiple environments with python3 installed in different locations.
duggelz
approved these changes
Apr 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary under --python_path=python3 and other relative paths,
which is in turn necessary to support builds across multiple environments
with python3 installed in different locations.
This fixes an error like:
Traceback (most recent call last):
File "bazel-out/host/bin/external/subpar/compiler/compiler", line 172, in
Main()
File "bazel-out/host/bin/external/subpar/compiler/compiler", line 145, in Main
raise AssertionError('Could not find python binary: ' + PYTHON_BINARY)
AssertionError: Could not find python binary: python3
When running the compiler as a dependency of a par_* rule.