Conversation
Add option to use locally cloned via install or remote via main project network orchestrator
Fix orchestrator exiting only after timeout
Change result format to match closer to design doc
jboddey
approved these changes
Apr 25, 2023
| test_module_timeout = time.time() + module.timeout | ||
| status = self._get_module_status(module) | ||
|
|
||
| while time.time() < test_module_timeout or status == 'exited': |
Contributor
There was a problem hiding this comment.
@jhughesbiot Could you take a look at this check. The container status seems to never differ from 'created' even if it is running or exited.
| "display_name": "Baseline", | ||
| "description": "Baseline test" | ||
| }, | ||
| "network": { |
Contributor
There was a problem hiding this comment.
Why would the test module developer need to change the interface name? Is this too much flexibility?
| }, | ||
| "network": { | ||
| "interface": "eth0", | ||
| "enable_wan": false, |
Contributor
There was a problem hiding this comment.
No test module should have WAN as an option. They will have internet access through the gateway. The ip for the test container should just be auto-generated (maybe a fixed IP for all the test containers or just DHCP?)
| while time.time() < test_module_timeout and status == 'running': | ||
| time.sleep(1) | ||
| status = self._get_module_status(module) | ||
|
|
Contributor
There was a problem hiding this comment.
Let's stop/kill the container and send different log message if module overruns the timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the initial framework for the test orchestrator and a test template.