Skip to content

Cleanup reference - #449

Closed
polettif wants to merge 4 commits into
google:masterfrom
polettif:cleanup-reference
Closed

Cleanup reference#449
polettif wants to merge 4 commits into
google:masterfrom
polettif:cleanup-reference

Conversation

@polettif

@polettif polettif commented May 2, 2024

Copy link
Copy Markdown

While trying to parse reference.md I noticed some inconsistencies in how names are used. This is just a "typo" PR which uses the same naming pattern for all fields. Please let me know if I'm missing some reason why "Required" was used as a column name instead of "Presence" for location_group and location_group_stops.

Also, the revision date (Nov 16, 2023) at the top is also not up-to-date but I refrained from changing that as well.

polettif added 3 commits May 2, 2024 10:25
fare_media, fare_products, fare_leg_rules, fare_transfer_rules
 location_group, location_group_stops
@google-cla

google-cla Bot commented May 2, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@polettif

polettif commented May 2, 2024

Copy link
Copy Markdown
Author

Ah, to be honest the CLA is too much of a hassle :) Feel free to use the info here in another pull request or somewhere down the line.

@polettif polettif closed this May 2, 2024
@eliasmbd

eliasmbd commented May 2, 2024

Copy link
Copy Markdown

Hello @polettif. Thank you for bringing this up. Sorry to hear you are having issues with the CLA. I will pass this along to the team at MobilityData and we can get back to you. Do you mind if we re-open this editorial PR regardless of CLA status?

@polettif

polettif commented May 3, 2024

Copy link
Copy Markdown
Author

I will pass this along to the team at MobilityData and we can get back to you. Do you mind if we re-open this editorial PR regardless of CLA status?

Thanks 👍 No, not at all

@polettif polettif reopened this May 3, 2024
@tzujenchanmbd

Copy link
Copy Markdown
Collaborator

Closing this PR as #453 merged.

Thanks again @polettif !

@polettif
polettif deleted the cleanup-reference branch May 16, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants