Mark images in Service Alerts as final - #651
Open
gcamp wants to merge 1 commit into
Open
Conversation
Remove the experimental tag from Alert.image, Alert.image_alternative_text and the TranslatedImage message, in both the .proto and reference.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
image,image_alternative_textand theTranslatedImagemessage have been in the spec since September 2021. This PR removes their experimental tag.Type of change
GTFS Realtime
Proposed Discussion Period
7 calendar day (minimum)
Testing Details
One caveat on the consumer side: Transit parses both fields and can display the image alongside the alert, but it isn't enabled by default today — it has to be manually enabled for the image to be shown to riders. There's plans to show it by default in the future. In the list of producers, we currently only show Metro Transit and TransLink.
Proposal Update Tracker