Propagate Log Update Failures in AddSequencedLeaves#1544
Propagate Log Update Failures in AddSequencedLeaves#1544mhutchinson merged 4 commits intogoogle:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1544 +/- ##
==========================================
+ Coverage 66.12% 67.24% +1.12%
==========================================
Files 103 105 +2
Lines 7013 8586 +1573
==========================================
+ Hits 4637 5774 +1137
- Misses 1884 2230 +346
- Partials 492 582 +90
Continue to review full report at Codecov.
|
gdbelvin
left a comment
There was a problem hiding this comment.
Thanks for submitting this much needed change.
Just a few suggestions on using the status library for easier handling of the status
I'll also loop in @Martin2112 for his approval.
|
wdyt @Martin2112 ? |
gdbelvin
left a comment
There was a problem hiding this comment.
Approving.
@Martin2112 FYI
| LogId: c.LogID, | ||
| Leaves: leaves, | ||
| }) | ||
| for _, leaf := range resp.GetResults() { |
There was a problem hiding this comment.
It looks like the client doesn't get to find out which leaves already exist. Maybe that doesn't matter.
|
/gcbrun |
Co-Authored-By: therealdrake <alexdrake@google.com>
Co-Authored-By: therealdrake <alexdrake@google.com>
|
/gcbrun |
AddSequencedLeaves in the log client previously did not evaluate the response proto. Adding some fail case checking and logging.