Manually vendor the required .proto files from googleapis#2765
Merged
mhutchinson merged 5 commits intogoogle:masterfrom Jun 22, 2022
Merged
Manually vendor the required .proto files from googleapis#2765mhutchinson merged 5 commits intogoogle:masterfrom
mhutchinson merged 5 commits intogoogle:masterfrom
Conversation
This resolves some weird references to GOPATH, that while it worked, was weird (google#2763). It also simplifies new user onboarding (one less instruction to follow), makes CI more lightweight (one less big repo to clone), and avoids mismatched versions of these protos from causing havoc (because they were less hermetic before).
pav-kv
reviewed
Jun 21, 2022
pav-kv
reviewed
Jun 21, 2022
Contributor
|
What was the sequence of actions you did to create this? Was it a copy-paste, or some "submodule" magic? It would be nice to expand the README a bit, to know how to update this dependency in the future. |
AlCutter
reviewed
Jun 21, 2022
Contributor
Author
Yeah that's a good question. I've documented it in the README, and confirmed that the distilled steps I've put in there replace the |
pav-kv
approved these changes
Jun 21, 2022
Contributor
pav-kv
left a comment
pav-kv
left a comment
There was a problem hiding this comment.
LGTM in principle, see some more nits.
AlCutter
approved these changes
Jun 22, 2022
Contributor
|
Still LGTM. Maybe worth mentioning in CHANGELOG? |
Contributor
Author
|
Added section to changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves some weird references to GOPATH, that while it worked, was weird (#2763). It also simplifies new user onboarding (one less instruction to follow), makes CI more lightweight (one less big repo to clone), and avoids mismatched versions of these protos from causing havoc (because they were less hermetic before).