Move golangci-lint from Cloud Build to GitHub Action#3188
Merged
roger2hk merged 1 commit intogoogle:masterfrom Nov 8, 2023
Merged
Move golangci-lint from Cloud Build to GitHub Action#3188roger2hk merged 1 commit intogoogle:masterfrom
roger2hk merged 1 commit intogoogle:masterfrom
Conversation
8de6b02 to
dc03836
Compare
Contributor
Author
|
I have no clue why the trillian-pr-tests keeps failing. |
Member
|
Seems to be failing to look up the ip address of the DB host, although I'm not sure why this should have just started happening... |
Contributor
|
Any insights into what the problem with the DB connection is? Seems suspicious that it's happened so soon after the upgrade to MySQL 8, but weird that it's happening on this PR now. Looks like other PRs have gone in fine since. I've made the target re-run but I assume someone has already tried that? |
Contributor
|
Looks like it was just a flake. |
mhutchinson
approved these changes
Nov 8, 2023
Contributor
Author
Thanks Martin. I guess I had some bad luck on that day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cloud Build duration will be slightly shorten by moving the golangci-lint to GitHub Action workflow.
Checklist