Switch from using unmaintained Google Cloud mysql db image to dockerhub official image#3272
Merged
mhutchinson merged 1 commit intogoogle:masterfrom Jan 10, 2024
Merged
Conversation
…ub official image https://github.com/GoogleCloudPlatform/mysql-docker claims it is unmaintained and hasn't seen an update in 5 months. Without a specific reason for using this fork we should try using the official image on dockerhub which is less likely to see breakages or fall out of date. Instead of pinning to a hash I'm following the 8.0 tag to automatically receive patch versions. The reasoning being that the container is used during testing and is not an included dependency in our final artifact. Happy to consider pinning if anybody thinks there is a call for it.
Contributor
|
/gcbrun |
mhutchinson
approved these changes
Jan 10, 2024
Contributor
mhutchinson
left a comment
mhutchinson
left a comment
There was a problem hiding this comment.
Tests seem to pass, so LGTM. I suspect we can/should remove the steps from the cloudbuild files that create the gcr.io/trillian-opensource-ci/mysql8 image from the unmaintained project.
mhutchinson
added a commit
to mhutchinson/trillian
that referenced
this pull request
Jan 10, 2024
Superflous after google#3272 was merged
mhutchinson
added a commit
that referenced
this pull request
Jan 10, 2024
Superflous after #3272 was merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #3270
https://github.com/GoogleCloudPlatform/mysql-docker claims it is unmaintained and
hasn't seen an update in 5 months. Without a specific reason for using this fork
we should try using the official image on dockerhub which is less likely to see breakages
or fall out of date.
Instead of pinning to a hash I'm following the 8.0 tag to automatically receive patch versions.
The reasoning being that the container is used during testing and is not
an included dependency in our final artifact. Happy to consider pinning
if anybody thinks there is a call for it.
Checklist