Sensible default quota and storage systems when MySQL support unavailable#3679
Merged
roger2hk merged 2 commits intogoogle:masterfrom Nov 22, 2024
Merged
Conversation
Contributor
|
/gcbrun |
roger2hk
reviewed
Nov 16, 2024
roger2hk
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It no longer makes sense to hardcode "mysql" as the default value for
-quota_systemand-storage_system, because after #3664 it's now possible to omit MySQL support when building the log_server and log_signer.For backwards compatibility "mysql" should remain the default when MySQL support is available, but otherwise an available storage system and an available (and if possible matching) quota system should be the default.
Checklist