Skip to content

Improve PostgreSQL functions #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roger2hk merged 4 commits into from
Apr 10, 2025
Merged

Improve PostgreSQL functions #3770

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aff940c
Optimize the case of <1000 rows in the PostgreSQL count_estimate() fu…
robstradling Apr 3, 2025
d0cecaa
Combine LOCK TABLE statements
robstradling Apr 3, 2025
2967f3c
Remove redundant RETURN statements
robstradling Apr 3, 2025
fc8dd08
Update CHANGELOG.md
robstradling Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Combine LOCK TABLE statements
  • Loading branch information
@robstradling
robstradling committed Apr 3, 2025
commit d0cecaae6c43a388ebaa4d5be6c460a94b6d3d86
6 changes: 2 additions & 4 deletions storage/postgresql/schema/storage.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,7 @@ CREATE OR REPLACE FUNCTION queue_leaves(
) RETURNS SETOF bytea
LANGUAGE plpgsql AS $$
BEGIN
LOCK TABLE LeafData IN SHARE ROW EXCLUSIVE MODE;
LOCK TABLE Unsequenced IN SHARE ROW EXCLUSIVE MODE;
LOCK TABLE LeafData, Unsequenced IN SHARE ROW EXCLUSIVE MODE;
UPDATE TempQueueLeaves t
SET IsDuplicate = TRUE
FROM LeafData l
Expand All @@ -196,8 +195,7 @@ CREATE OR REPLACE FUNCTION add_sequenced_leaves(
) RETURNS TABLE(leaf_identity_hash bytea, is_duplicate_leaf_data boolean, is_duplicate_sequenced_leaf_data boolean)
LANGUAGE plpgsql AS $$
BEGIN
LOCK TABLE LeafData IN SHARE ROW EXCLUSIVE MODE;
LOCK TABLE SequencedLeafData IN SHARE ROW EXCLUSIVE MODE;
LOCK TABLE LeafData, SequencedLeafData IN SHARE ROW EXCLUSIVE MODE;
UPDATE TempAddSequencedLeaves t
SET IsDuplicateLeafData = TRUE
FROM LeafData l
Expand Down