Add TryFromBytes::try_{ref,mut}_from_{bytes,prefix,suffix}_with_elems#1747
Merged
Add TryFromBytes::try_{ref,mut}_from_{bytes,prefix,suffix}_with_elems#1747
Conversation
jswrenn
force-pushed
the
try-from-bytes-with-elems-methods
branch
2 times, most recently
from
5cdb8d8 to
b0d1b2f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1747 +/- ##
==========================================
- Coverage 88.01% 87.13% -0.89%
==========================================
Files 16 16
Lines 5833 5892 +59
==========================================
Hits 5134 5134
- Misses 699 758 +59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jswrenn
approved these changes
Sep 24, 2024
joshlf
commented
Sep 24, 2024
jswrenn
force-pushed
the
try-from-bytes-with-elems-methods
branch
from
b0d1b2f to
cb103be
Compare
Collaborator
|
Hit merge when you're satisfied, @joshlf. |
joshlf
commented
Sep 24, 2024
| count: usize, | ||
| ) -> Result<&mut Self, TryCastError<&mut [u8], Self>> | ||
| where | ||
| Self: KnownLayout<PointerMetadata = usize> + Immutable, |
Member
Author
There was a problem hiding this comment.
Remove the Immutable bound?
| count: usize, | ||
| ) -> Result<(&mut Self, &mut [u8]), TryCastError<&mut [u8], Self>> | ||
| where | ||
| Self: KnownLayout<PointerMetadata = usize> + Immutable, |
Member
Author
There was a problem hiding this comment.
Remove the Immutable bound?
| count: usize, | ||
| ) -> Result<(&mut [u8], &mut Self), TryCastError<&mut [u8], Self>> | ||
| where | ||
| Self: KnownLayout<PointerMetadata = usize> + Immutable, |
Member
Author
There was a problem hiding this comment.
Remove the Immutable bound?
Makes progress on #5
joshlf
commented
Sep 24, 2024
| /// use zerocopy::*; | ||
| /// # use zerocopy_derive::*; | ||
| /// | ||
| /// #[derive(TryFromBytes, Immutable, KnownLayout)] |
Member
Author
There was a problem hiding this comment.
Don't derive Immutable here?
| /// # use zerocopy_derive::*; | ||
| /// | ||
| /// // The only valid value of this type is the byte `0xC0` | ||
| /// #[derive(TryFromBytes, KnownLayout, Immutable)] |
Member
Author
There was a problem hiding this comment.
Don't derive Immutable here?
| /// # use zerocopy_derive::*; | ||
| /// | ||
| /// // The only valid value of this type is the byte `0xC0` | ||
| /// #[derive(TryFromBytes, KnownLayout, Immutable)] |
Member
Author
There was a problem hiding this comment.
Don't derive Immutable here?
| /// use zerocopy::*; | ||
| /// # use zerocopy_derive::*; | ||
| /// | ||
| /// #[derive(TryFromBytes, Immutable, KnownLayout)] |
Member
Author
There was a problem hiding this comment.
Don't derive Immutable here?
| /// # use zerocopy_derive::*; | ||
| /// | ||
| /// // The only valid value of this type is the byte `0xC0` | ||
| /// #[derive(TryFromBytes, KnownLayout, Immutable)] |
Member
Author
There was a problem hiding this comment.
Don't derive Immutable here?
| /// use zerocopy::*; | ||
| /// # use zerocopy_derive::*; | ||
| /// | ||
| /// #[derive(TryFromBytes, Immutable, KnownLayout)] |
Member
Author
There was a problem hiding this comment.
Don't derive Immutable here?
jswrenn
force-pushed
the
try-from-bytes-with-elems-methods
branch
from
cb103be to
95a8ca7
Compare
Collaborator
Member
Author
|
Awesome, queued! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes progress on #5