Closed
Conversation
jswrenn
force-pushed
the
more-transmute-ui-tests
branch
3 times, most recently
from
0651e9a to
665ddc1
Compare
Adds tests of size changes and unmet trait bounds. A test-per-file approach is taken so that reviewers of future PRs that alter the implementation details of `transmute!` can assess each dimension of change discretely and incrementally — as opposed to contending with `.stderr` files hundreds of lines in length. Co-authored-by: Joshua Liebow-Feeser <joshlf@google.com>
jswrenn
force-pushed
the
more-transmute-ui-tests
branch
from
665ddc1 to
59917e3
Compare
Member
|
Implemented in #456. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that I was unable to easily review changes made atop #183 due to its omnibus UI test producing very long stderr files. This PR lifts the tests of
transmute!added in #183, but takes a test-per-file-approach. A test-per-file approach is taken so that reviewers of future PRs that alter the implementation details oftransmute!can assess each dimension of change discretely and incrementally — as opposed to contending with.stderrfiles hundreds of lines in length.