[pointer] SizeEq supports raw pointer transmutes#2422
Closed
joshlf wants to merge 1 commit intoI3d825b6c6b99277c96d9fd6a6761bdfad2000473from
Closed
[pointer] SizeEq supports raw pointer transmutes#2422joshlf wants to merge 1 commit intoI3d825b6c6b99277c96d9fd6a6761bdfad2000473from
joshlf wants to merge 1 commit intoI3d825b6c6b99277c96d9fd6a6761bdfad2000473from
Conversation
joshlf
force-pushed
the
I090715fd9ed6f100fd35513b05054015621ecb9c
branch
from
9eed6ef to
5f3623e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## I3d825b6c6b99277c96d9fd6a6761bdfad2000473 #2422 +/- ##
=============================================================================
- Coverage 88.03% 87.53% -0.51%
=============================================================================
Files 17 18 +1
Lines 6412 6408 -4
=============================================================================
- Hits 5645 5609 -36
- Misses 767 799 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
I090715fd9ed6f100fd35513b05054015621ecb9c
branch
from
5f3623e to
dff5d0c
Compare
This was referenced Mar 6, 2025
This permits us to remove the `KnownLayout` bounds from `Ptr::transmute`, and thus to remove `Ptr::transmute_sized` entirely. This also allows us to remove the hand-rolled impl of `TryFromBytes` for `ManuallyDrop<T>`, replacing it with an invocation of `impl_for_transmute_from!`. gherrit-pr-id: I090715fd9ed6f100fd35513b05054015621ecb9c
joshlf
force-pushed
the
I090715fd9ed6f100fd35513b05054015621ecb9c
branch
from
dff5d0c to
b544516
Compare
joshlf
changed the base branch from
main
to
I3d825b6c6b99277c96d9fd6a6761bdfad2000473
auto-merge was automatically disabled
March 7, 2025 18:50
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This permits us to remove the
KnownLayoutbounds fromPtr::transmute, and thus to removePtr::transmute_sizedentirely.This also allows us to remove the hand-rolled impl of
TryFromBytesforManuallyDrop<T>, replacing it with an invocation ofimpl_for_transmute_from!.This PR is on branch cell-traits.