Closed
Conversation
Some raw pointer casts now have the signature `fn(PtrInner) -> PtrInner` instead of `fn(PtrInner) -> NonNull`. Simplify the implementations of some `Ptr` methods. Co-authored-by: Jack Wrenn <jswrenn@amazon.com> gherrit-pr-id: I1945c8e554dd80a0475462d0dc5e0ae1eb2e9ac4
This was referenced Jun 9, 2025
auto-merge was automatically disabled
June 9, 2025 19:12
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some raw pointer casts now have the signature
fn(PtrInner) -> PtrInnerinstead of
fn(PtrInner) -> NonNull. Simplify the implementations ofsome
Ptrmethods.Co-authored-by: Jack Wrenn jswrenn@amazon.com
This PR is on branch transmute-ref-dst.