zerocopy: add SPDX-License-Identifier to source files#3432
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3432 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 20 20
Lines 6093 6093
=======================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joshlf
left a comment
There was a problem hiding this comment.
Tiny nit, but otherwise looks good, thanks! You'll also need to rebase on main.
|
Oh and also, you'll need to run |
Made the changes and rebased on |
acf3b1b to
e75dfeb
Compare
Fixes google#3428 Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com>
|
I have removed the accidental generated-output churn, and the branch now contains only the SPDX changes in .rs files. I haven’t committed the UI expected-output changes because running |
|
Looks like I can't push to your branch, but I put up a new PR with your commit (but rebased and having re-run the UI test generation): #3455. |
Thanks, should i close this one ? |
|
Yeah I was waiting to see whether the tests passed on the other one, which they now have, so closing this. |
Fixes #3428