Skip to content

zerocopy: add SPDX-License-Identifier to source files#3432

Closed
Sagartaunk wants to merge 1 commit into
google:mainfrom
Sagartaunk:main
Closed

zerocopy: add SPDX-License-Identifier to source files#3432
Sagartaunk wants to merge 1 commit into
google:mainfrom
Sagartaunk:main

Conversation

@Sagartaunk

Copy link
Copy Markdown
Contributor

Fixes #3428

@google-cla

google-cla Bot commented Jun 4, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter

codecov-commenter commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (8d7db04) to head (97b5894).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3432   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          20       20           
  Lines        6093     6093           
=======================================
  Hits         5597     5597           
  Misses        496      496           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf joshlf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit, but otherwise looks good, thanks! You'll also need to rebase on main.

Comment thread zerocopy/src/pointer/inner.rs
@joshlf

joshlf commented Jun 5, 2026

Copy link
Copy Markdown
Member

Oh and also, you'll need to run ./tools/update-expected-test-output.sh after you've made any changes.

@Sagartaunk

Copy link
Copy Markdown
Contributor Author

Oh and also, you'll need to run ./tools/update-expected-test-output.sh after you've made any changes.

Made the changes and rebased on main. Also, are there any good first issues you'd recommend to someone looking to contribute more?

@Sagartaunk Sagartaunk requested a review from joshlf June 6, 2026 05:52
@Sagartaunk Sagartaunk force-pushed the main branch 2 times, most recently from acf3b1b to e75dfeb Compare June 8, 2026 11:17
Fixes google#3428

Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com>
@Sagartaunk

Copy link
Copy Markdown
Contributor Author

I have removed the accidental generated-output churn, and the branch now contains only the SPDX changes in .rs files. I haven’t committed the UI expected-output changes because running ./tools/update-expected-test-output.sh also modifies the bench output on my machine, I am not sure why. Since those bench changes seem unrelated to this PR, I left all generated output out for now.

@joshlf

joshlf commented Jun 9, 2026

Copy link
Copy Markdown
Member

Looks like I can't push to your branch, but I put up a new PR with your commit (but rebased and having re-run the UI test generation): #3455.

@Sagartaunk

Copy link
Copy Markdown
Contributor Author

Looks like I can't push to your branch, but I put up a new PR with your commit (but rebased and having re-run the UI test generation): #3455.

Thanks, should i close this one ?

@joshlf

joshlf commented Jun 9, 2026

Copy link
Copy Markdown
Member

Yeah I was waiting to see whether the tests passed on the other one, which they now have, so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux kernel: SPDX license identifiers

3 participants