Skip to content

Symfony 4 support#401

Merged
fiboknacky merged 1 commit into
googleads:masterfrom
JonEastman:symfony-4-update
Nov 22, 2017
Merged

Symfony 4 support#401
fiboknacky merged 1 commit into
googleads:masterfrom
JonEastman:symfony-4-update

Conversation

@JonEastman

Copy link
Copy Markdown
Contributor

Added Symfony 4 support.

#SymfonyConHackday2017

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@JonEastman

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@fiboknacky

Copy link
Copy Markdown
Member

Will have a look soon.

@JonEastman

Copy link
Copy Markdown
Contributor Author

@fiboknacky sounds good. Thank you!

@fiboknacky fiboknacky merged commit 1951517 into googleads:master Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants