This repository was archived by the owner on Mar 26, 2026. It is now read-only.
chore(test): test receiving known and unknown enums#1442
Closed
vchudnov-g wants to merge 5 commits intogoogleapis:mainfrom
Closed
chore(test): test receiving known and unknown enums#1442vchudnov-g wants to merge 5 commits intogoogleapis:mainfrom
vchudnov-g wants to merge 5 commits intogoogleapis:mainfrom
Conversation
vchudnov-g
force-pushed
the
numericenum-showcase
branch
from
c6ec883 to
4abfbe4
Compare
product-auto-label
bot
added
size: s
vchudnov-g
force-pushed
the
numericenum-showcase
branch
from
06824d8 to
e4e5ff2
Compare
Locally run nox showcase_unit-3.8, for example, and look for "FIXME" in the output. You'll see that the the test expects `info.f_kingdom=compliance.ComplianceData.LifeKingdom.ARCHAEBACTERIA' but the actual mock call returns `info.f_kingdom=LifeKingdom.ARCHAEBACTERIA'. This blocks the CI from passing on this PR.
vchudnov-g
force-pushed
the
numericenum-showcase
branch
from
a95ad9e to
7e41956
Compare
Contributor
|
Closing as stale. Please re-open if this is still being worked on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides test for #1407
In a subsequent PR, it will be expanded to include compliance_suite testing.
This is based heavily on @atulep 's PR#1424