This repository was archived by the owner on Nov 18, 2025. It is now read-only.
fix: add dependency to fix tests - #1658
Merged
Merged
Conversation
leahecole
force-pushed
the
resolve_pdfmake
branch
from
September 23, 2024 16:42
bc1bdd0 to
1ef68bb
Compare
leahecole
marked this pull request as ready for review
September 23, 2024 16:46
leahecole
marked this pull request as draft
September 23, 2024 18:25
leahecole
marked this pull request as ready for review
September 23, 2024 18:41
leahecole
force-pushed
the
resolve_pdfmake
branch
from
September 23, 2024 18:41
1a7bbc4 to
9f17b35
Compare
leahecole
changed the title
Contributor
|
Can you add a todo to remove this dependency and compodoc when we move off of it? Ty! |
Contributor
Author
googleapis/google-cloud-node-core#201 has been added! :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per our discussion in the JS team meeting, add pdfmake as a direct dependency to fix googleapis/google-cloud-node-core#202