encodeURIComponent all url parameters

[ryanseys]

A developer ran into an issue (#268) and the fix was to url encode his parameters. We should be doing this by default for URL parameters that will end up in the url.

[Quentin01]

For my use case with Google Calendar API, I retrieve all calendars and events on them. But I have a Calendar with an ID ( "fr.french#holiday@group.v.calendar.google.com" ) which must be encoded with encodeURIComponent to work when I use this SDK.

[ryanseys]

Query parameters are fine, they are handled by request. But those that end up in the url path will need to all be encodeURIComponent'd

[ryanseys]

Unfortunately this is going to require a change to every single API 😢 I can reduce the pain of this by factoring that logic into createAPIRequest and modifying the url and media url to be built in createAPIRequest using util.format, moving more of the logic out of the API template.

Old url:
'https://www.googleapis.com/calendar/v3/users/me/calendarList/' + params.calendarId

New url:
'https://www.googleapis.com/calendar/v3/users/me/calendarList/{calendarId}'

Then format using something like this: https://gist.github.com/ryanseys/856471207aa3f80ff614

[robertrossmann]

I use this for such string manipulation... So far, so good.

[ssorallen]

The introduction of URI encoding made sense to me, and we happened to be using a version of this library where it was included. The auto-encoding was reverted in commit fbcb962#diff-9475ffcd397ad130248cf92c9a813d65 with no explanation though. Is it intentional that this library expects the user to encodeURIComponent parameters before passing them?

My issue is similar to @Quentin01: a calendar with a hash in it like "fr.french#holiday@group.v.calendar.google.com" constructs an invalid URL. Something like the following:

googleapis.calendar.client(/* params */).events.list({
    calendarId: 'fr.french#holiday@group.v.calendar.google.com'
});

attempts to load the following URL:

https://content.googleapis.com/calendar/v3/calendars/fr.french#holiday@group.v.calendar.google.com/events

Since a # is a reserved character, the googleapis client returns a 404 after attempting to load only https://content.googleapis.com/calendar/v3/calendars/fr.french.