On 500 responses from .getToken(...) requests, there is no error handling.

[omasrii]

For example on a 502 response, the tokens object is filled with the HTML error page.

tokens =

<title>Error 502 (Server Error)!!1</title> <style> _{margin:0;padding:0}html,code{font:15px/22px arial,sans-serif}html{background:#fff;color:#222;padding:15px}body{margin:7% auto 0;max-width:390px;min-height:180px;padding:30px 0 15px}_ > body{background:url(//www.google.com/images/errors/robot.png) 100% 5px no-repeat;padding-right:205px}p{margin:11px 0 22px;overflow:hidden}ins{color:#777;text-decoration:none}a img{border:0}@media screen and (max-width:772px){body{background:none;margin-top:0;max-width:none;padding-right:0}}#logo{background:url(//www.google.com/images/errors/logo_sm_2.png) no-repeat}@media only screen and (min-resolution:192dpi){#logo{background:url(//www.google.com/images/errors/logo_sm_2_hr.png) no-repeat 0% 0%/100% 100%;-moz-border-image:url(//www.google.com/images/errors/logo_sm_2_hr.png) 0}}@media only screen and (-webkit-min-device-pixel-ratio:2){#logo{background:url(//www.google.com/images/errors/logo_sm_2_hr.png) no-repeat;-webkit-background-size:100% 100%}}#logo{display:inline-block;height:55px;width:150px} </style>

502. That’s an error.

The server encountered a temporary error and could not complete your request.

Please try again in 30 seconds. That’s all we know.

[aarosil]

I was about to open an issue for this same thing. I was on 0.7.0, upgrading to 1.0.14 now to see if it still happens.

EDIT: Yep, I'm still seeing it w/ the latest version.

[ryanseys]

Hmm, yes, we just give back what we see so I don't see this as a big issue. That being said, perhaps we can detect the 502 and return a better error or some sort of error.

[aarosil]

It is kind of an issue, it doesn't follow the node standard of
callback(err, result). Err will always be null apparently, people are used
to checking for that.

Ideally you could have the http response as a property of the error also,
so we can detect what action to take as a result (retry, etc).

As of now all we can do is check for the token properties, and if they're
not there, try to extract the response code from the html

On Sun, Oct 5, 2014 at 8:17 PM, Ryan Seys notifications@github.com wrote:

Hmm, yes, we just give back what we see so I don't see this as a big
issue. That being said, perhaps we can detect the 502 and return a better
error or some sort of error.

—
Reply to this email directly or view it on GitHub
#293 (comment)
.

[robertrossmann]

I, too, feel we should be handling these responses in a more expectable manner. At least we should detect any non-ok HTTP response code and throw some generic error like Server responded with HTTP error xxx and return it in the callback.

Let's see if I can hack together a PR for this...

[robertrossmann]

This is interesting. After having a quick peek at the code, there are error handlers all over the place which should return err when an HTTP error occurs. Unless, however, the request library does not consider codes above 399 as errors...Which feels a bit odd, to be honest.

[ryanseys]

Possible fix in #304 take a look

[ryanseys]

What .getToken() are you calling? Is this for JWT or OAuth2Client?

[aarosil]

@ryanseys looks good, I'm not sure what @omarnmasri opened this for but I faced it with auth.OAuth2.refreshAccessToken()

[omasrii]

@aarosil I opened this for OAuth2Client.refreshAccessToken() as you said.

[ryanseys]

Released as 1.0.17